Review Request 109422: Fix mingw64 compiler errors

[Florian Eßer]

> On March 11, 2013, 4:17 p.m., Aleix Pol Gonzalez wrote:
> > Looks good, please add all the files and I think it's safe to push it.
> > 
> > BTW, why did you need to change the export tag?

Yes, I forgot the file. Just added it with the diff update.

What about the changed typecast? I don't want to break anything for 32bit-systems...


I needed to change the export tag, because the ...export.h macro was looking for "#ifdef MAKE_KDEVPLATFORMTESTS_LIB" to determine wether to use KDE_EXPORT or KDE_IMPORT.
CMake however calls the compiler with -DMAKE_KDEVPLATFORMJSONTESTS_LIB.

I dit not find where that is defined, seems to be something automagically.

However, some googling pointed me to:
http://www.cmake.org/pipermail/cmake/2008-July/023134.html 

"CMake sets the MAKE_KDEVPLATFORMINTERFACES_LIB define when building the library (the general form is MAKE_<targetname>_LIB) and then KDE_EXPORT is automtaically set to the right export definition depending on your platform."


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109422/#review28996
-----------------------------------------------------------


On March 11, 2013, 4:08 p.m., Florian Eßer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109422/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 4:08 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I tried to "emerge kdevplatform" under Windows7 / mingw64, but ran into some errors.
> 
> These are the fixes I used to make it compile again.
> 
> 
> Diffs
> -----
> 
>   language/codecompletion/normaldeclarationcompletionitem.cpp d0456b2 
>   tests/json/CMakeLists.txt 68550b6 
>   tests/json/declarationvalidator.h 2a1d971 
>   tests/json/delayedoutput.h 8b3fea1 
>   tests/json/jsontesthelpers.h 8f62f4a 
>   tests/json/kdevplatformjsontestsexport.h e69de29 
>   tests/json/testsuite.h 51f5051 
> 
> Diff: http://git.reviewboard.kde.org/r/109422/diff/
> 
> 
> Testing
> -------
> 
> "emerge kdevplatform" now finishes without error.
> 
> 
> Thanks,
> 
> Florian Eßer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130311/587f614a/attachment.html>