<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109422/">http://git.reviewboard.kde.org/r/109422/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 11th, 2013, 4:17 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, please add all the files and I think it's safe to push it.
BTW, why did you need to change the export tag?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I forgot the file. Just added it with the diff update.
What about the changed typecast? I don't want to break anything for 32bit-systems...
I needed to change the export tag, because the ...export.h macro was looking for "#ifdef MAKE_KDEVPLATFORMTESTS_LIB" to determine wether to use KDE_EXPORT or KDE_IMPORT.
CMake however calls the compiler with -DMAKE_KDEVPLATFORMJSONTESTS_LIB.
I dit not find where that is defined, seems to be something automagically.
However, some googling pointed me to:
http://www.cmake.org/pipermail/cmake/2008-July/023134.html
"CMake sets the MAKE_KDEVPLATFORMINTERFACES_LIB define when building the library (the general form is MAKE_<targetname>_LIB) and then KDE_EXPORT is automtaically set to the right export definition depending on your platform."
</pre>
<br />
<p>- Florian</p>
<br />
<p>On March 11th, 2013, 4:08 p.m. UTC, Florian Eßer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Florian Eßer.</div>
<p style="color: grey;"><i>Updated March 11, 2013, 4:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to "emerge kdevplatform" under Windows7 / mingw64, but ran into some errors.
These are the fixes I used to make it compile again.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"emerge kdevplatform" now finishes without error.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/codecompletion/normaldeclarationcompletionitem.cpp <span style="color: grey">(d0456b2)</span></li>
<li>tests/json/CMakeLists.txt <span style="color: grey">(68550b6)</span></li>
<li>tests/json/declarationvalidator.h <span style="color: grey">(2a1d971)</span></li>
<li>tests/json/delayedoutput.h <span style="color: grey">(8b3fea1)</span></li>
<li>tests/json/jsontesthelpers.h <span style="color: grey">(8f62f4a)</span></li>
<li>tests/json/kdevplatformjsontestsexport.h <span style="color: grey">(e69de29)</span></li>
<li>tests/json/testsuite.h <span style="color: grey">(51f5051)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109422/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>