Review Request 109422: Fix mingw64 compiler errors

Aleix Pol Gonzalez aleixpol at gmail.com
Mon Mar 11 16:17:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109422/#review28996
-----------------------------------------------------------


Looks good, please add all the files and I think it's safe to push it.

BTW, why did you need to change the export tag?


tests/json/CMakeLists.txt
<http://git.reviewboard.kde.org/r/109422/#comment21701>

    You forgot to add this file to the patch? I don't see it in kdevplatform...


- Aleix Pol Gonzalez


On March 11, 2013, 4:08 p.m., Florian Eßer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109422/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 4:08 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I tried to "emerge kdevplatform" under Windows7 / mingw64, but ran into some errors.
> 
> These are the fixes I used to make it compile again.
> 
> 
> Diffs
> -----
> 
>   language/codecompletion/normaldeclarationcompletionitem.cpp d0456b2 
>   tests/json/CMakeLists.txt 68550b6 
>   tests/json/declarationvalidator.h 2a1d971 
>   tests/json/delayedoutput.h 8b3fea1 
>   tests/json/jsontesthelpers.h 8f62f4a 
>   tests/json/kdevplatformjsontestsexport.h e69de29 
>   tests/json/testsuite.h 51f5051 
> 
> Diff: http://git.reviewboard.kde.org/r/109422/diff/
> 
> 
> Testing
> -------
> 
> "emerge kdevplatform" now finishes without error.
> 
> 
> Thanks,
> 
> Florian Eßer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130311/0ce47e3e/attachment.html>


More information about the KDevelop-devel mailing list