Review Request 108213: [2/3] Adjust KDevelop to EnvironmentSelectionWidget refactor.
Ivan Shapovalov
intelfx100 at gmail.com
Thu Jun 27 12:58:27 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108213/
-----------------------------------------------------------
(Updated June 27, 2013, 12:58 p.m.)
Review request for KDevelop.
Changes
-------
Removed custom properties on the combo-box in *.ui files since the widget doesn't inherit from KComboBox anymore.
Description
-------
A follow-up to https://git.reviewboard.kde.org/r/108212/.
This removes calls to addItems() and uses "" instead of "default" as default config values.
Diffs (updated)
-----
projectmanagers/custom-buildsystem/custombuildsystemconfigwidget.cpp 6934c43
projectmanagers/custom-buildsystem/configwidget.cpp bcd85c5
projectmanagers/cmake/settings/cmakepreferences.cpp c309fef
projectbuilders/makebuilder/makejob.cpp 1a8c2ce
projectbuilders/makebuilder/makeconfig.ui 592bba3
projectbuilders/makebuilder/makebuilderpreferences.cpp 5ffceb6
Diff: http://git.reviewboard.kde.org/r/108213/diff/
Testing
-------
Manual testing.
Thanks,
Ivan Shapovalov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130627/e97573c9/attachment.html>
More information about the KDevelop-devel
mailing list