Review Request 108212: [1/3] Refactor EnvironmentSelectionWidget.

[Ivan Shapovalov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108212/
-----------------------------------------------------------

(Updated June 27, 2013, 12:16 p.m.)


Review request for KDevelop.


Changes
-------

Removed KComboBox inheritance on the widget (as per Milian's comment) and fixed a bug in model (no drop-down list).


Description
-------

Feature-wise this gets rid of dependency on default KConfigXT value being "default" and allows explicitly specifying to use a default environment group whatever it will be.

Now an empty value shall be used by default, which has meaning of "use whatever is set by default at runtime".
Also, a special "Use default" line is now always added to the combo-box which maps to the empty config value, so user won't see empty entries in the combo-box.


Diffs (updated)
-----

  util/environmentselectionwidget.cpp 63fdebc 
  util/environmentselectionwidget.h 0784ba1 
  util/environmentselectionmodel.cpp PRE-CREATION 
  util/environmentselectionmodel.h PRE-CREATION 
  util/environmentconfigurebutton.cpp b95e536 
  util/CMakeLists.txt d7e56e8 
  plugins/executescript/scriptappconfig.cpp b8f0729 
  plugins/execute/nativeappconfig.cpp 8dc1999 

Diff: http://git.reviewboard.kde.org/r/108212/diff/


Testing
-------

Manual testing.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130627/ce43edf6/attachment.html>