Review Request 108214: [3/3] Adjust kdev-ninja to EnvironmentSelectionWidget refactor.
Ivan Shapovalov
intelfx100 at gmail.com
Thu Jun 27 12:59:38 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108214/
-----------------------------------------------------------
(Updated June 27, 2013, 12:59 p.m.)
Review request for KDevelop.
Changes
-------
Removed custom properties on the combo-box in *.ui files since the widget doesn't inherit from KComboBox anymore.
Description
-------
A follow-up to https://git.reviewboard.kde.org/r/108212/ .
This removes calls to addItems() and uses "" instead of "default" as default config values.
Diffs (updated)
-----
ninjaconfig.ui 520d7be
ninjabuilderpreferences.cpp 02aa353
ninjabuilderconfig.kcfg e1d3c13
Diff: http://git.reviewboard.kde.org/r/108214/diff/
Testing
-------
Manual testing.
Thanks,
Ivan Shapovalov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130627/9f09f4d5/attachment.html>
More information about the KDevelop-devel
mailing list