Review Request 111151: Fix incorrect debug session ending.

[Vlas Puhov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111151/
-----------------------------------------------------------

(Updated June 22, 2013, 9:36 a.m.)


Review request for KDevelop.


Changes
-------

Description:
* used 1 RegExp
* a little bit of code integration
* added unit test

Thanks for your review.

Nicolai Hähnle:
1. Yeah, actually it's a good idea.
2. I've tried it. parseStreamRecord returns a streamRecord, but we want to get a resultRecord, so it doesn't work.
3. About typo. Yeah, thank you, I'm not good at English, actually I'm surprised there's only one such thing. ;)

Aleix Pol Gonzalez:
  I've tried to integrate the last patch as far as I could, but the code in MIParser is very... unreadable for me at least, I just can't figure out what is going on there.:(
  I didn't now till now that such thing as unit test exists ;)... so, I wrote one, but I have no idea if I did it the right way...


Description
-------

If commands like c, n, ni,si... were send directly to gdb, it may exit with message like "~\"[Inferior * (process *) exited *", but miparser treats it like usual message. 


Diffs (updated)
-----

  debuggers/gdb/mi/miparser.h 7096af0 
  debuggers/gdb/mi/miparser.cpp a17e644 
  debuggers/gdb/unittests/gdbtest.h bd5d90d 
  debuggers/gdb/unittests/gdbtest.cpp efcab9d 

Diff: http://git.reviewboard.kde.org/r/111151/diff/


Testing
-------


Thanks,

Vlas Puhov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130622/dcd24fd4/attachment.html>