<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111151/">http://git.reviewboard.kde.org/r/111151/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Vlas Puhov.</div>
<p style="color: grey;"><i>Updated June 22, 2013, 9:36 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Description:
* used 1 RegExp
* a little bit of code integration
* added unit test
Thanks for your review.
Nicolai Hähnle:
1. Yeah, actually it's a good idea.
2. I've tried it. parseStreamRecord returns a streamRecord, but we want to get a resultRecord, so it doesn't work.
3. About typo. Yeah, thank you, I'm not good at English, actually I'm surprised there's only one such thing. ;)
Aleix Pol Gonzalez:
I've tried to integrate the last patch as far as I could, but the code in MIParser is very... unreadable for me at least, I just can't figure out what is going on there.:(
I didn't now till now that such thing as unit test exists ;)... so, I wrote one, but I have no idea if I did it the right way...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If commands like c, n, ni,si... were send directly to gdb, it may exit with message like "~\"[Inferior * (process *) exited *", but miparser treats it like usual message. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/gdb/mi/miparser.h <span style="color: grey">(7096af0)</span></li>
<li>debuggers/gdb/mi/miparser.cpp <span style="color: grey">(a17e644)</span></li>
<li>debuggers/gdb/unittests/gdbtest.h <span style="color: grey">(bd5d90d)</span></li>
<li>debuggers/gdb/unittests/gdbtest.cpp <span style="color: grey">(efcab9d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111151/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>