Review Request 111151: Fix incorrect debug session ending.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111151/#review34817
-----------------------------------------------------------



debuggers/gdb/mi/miparser.cpp
<http://git.reviewboard.kde.org/r/111151/#comment25522>

    Brace goes down



debuggers/gdb/mi/miparser.cpp
<http://git.reviewboard.kde.org/r/111151/#comment25523>

    if you want to assert on i==0, you can do it before. Also you can use QRegExp::exactMatch for making sure it's matching all the expression.
    
    also you could do it both with 1 QRegExp. It would end up cleaner


I'm not proficient in that codebase, but to me it looks like you're workarounding a bug in the lexer with these QRegExp.

I'd say that you can add support to the MIParser for that functionality instead of matching the one that is bugging us and feeding one that we understand. It will end up with a clearer codebase.

Additionally, if you could add a unit test for this in the gdbtest it would be /very/ appreciated. 

- Aleix Pol Gonzalez


On June 20, 2013, 3:55 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111151/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 3:55 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> If commands like c, n, ni,si... were send directly to gdb, it may exit with message like "~\"[Inferior * (process *) exited *", but miparser treats it like usual message. 
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/mi/miparser.h 7096af0 
>   debuggers/gdb/mi/miparser.cpp a17e644 
> 
> Diff: http://git.reviewboard.kde.org/r/111151/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130621/87e403f4/attachment-0001.html>