Review Request 111151: Fix incorrect debug session ending.

[Nicolai Hähnle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111151/#review34809
-----------------------------------------------------------


Hey Vlas,

speaking not as one of the developers but just as a user who ran into the same issue that this intends to solve I say thank you for looking into this.

I noticed a simple typo in miparser.h: "sended" should be "sent".

For the approach itself, I noticed two things to think about:

1. It would probably be cleaner and more efficient to use one single regexp that covers all the cases of the "Inferior process exited" message. Then you can also use rx.exactMatch() instead of tx.indexIn(), which should be both cleaner and faster as well.

2. Dealing with stream records (prefixed with ~) is already implemented in parseStreamRecords, and that takes care of some things that your manual approach does not. So perhaps it would be better to instead let parseStreamRecords do its usual thing, and then "filter" the resulting StreamRecord _after_ it has been completely parsed.

This would yield the same result with fewer "layering violations". At least, that's my outside observer's two cents.

- Nicolai Hähnle


On June 20, 2013, 3:55 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111151/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 3:55 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> If commands like c, n, ni,si... were send directly to gdb, it may exit with message like "~\"[Inferior * (process *) exited *", but miparser treats it like usual message. 
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/mi/miparser.h 7096af0 
>   debuggers/gdb/mi/miparser.cpp a17e644 
> 
> Diff: http://git.reviewboard.kde.org/r/111151/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130621/71dc9ffd/attachment.html>