Review Request 111779: Breakpoint model: use custom LocationRole for retrieve full path, Qt::DisplayRole for file's name.

[Vlas Puhov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111779/
-----------------------------------------------------------

(Updated July 29, 2013, 9:49 p.m.)


Review request for KDevelop.


Changes
-------

Fixed all issues, except "else if". IMO without it code is much ease to read. Furthermore all code in Breakpoint::data is written in that style too. And leaving it as is won't hurt anyway, because if (column == ConditionColumn && ...) we return and branch if (column == LocationColumn) won't be checked.


Description
-------

See mail list for details.


Diffs (updated)
-----

  debugger/breakpoint/breakpoint.h bc56e46 
  debugger/breakpoint/breakpoint.cpp 22bdbd0 
  debugger/breakpoint/breakpointmodel.h ab65d77 
  debugger/breakpoint/breakpointwidget.h 79453b0 
  debugger/breakpoint/breakpointwidget.cpp 7337a4e 

Diff: http://git.reviewboard.kde.org/r/111779/diff/


Testing
-------

All gdb unit tests are passed.


Thanks,

Vlas Puhov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130729/0d733de3/attachment.html>