Review Request 111779: Breakpoint model: use custom LocationRole for retrieve full path, Qt::DisplayRole for file's name.
Milian Wolff
mail at milianw.de
Mon Jul 29 18:25:13 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111779/#review36772
-----------------------------------------------------------
debugger/breakpoint/breakpoint.cpp
<http://git.reviewboard.kde.org/r/111779/#comment27150>
Prepending the .../ imo does not add any information, as all files will have that. Remove it please.
- Milian Wolff
On July 29, 2013, 5:49 p.m., Vlas Puhov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111779/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 5:49 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> See mail list for details.
>
>
> Diffs
> -----
>
> debugger/breakpoint/breakpoint.h bc56e46
> debugger/breakpoint/breakpoint.cpp 22bdbd0
> debugger/breakpoint/breakpointmodel.h ab65d77
> debugger/breakpoint/breakpointwidget.h 79453b0
> debugger/breakpoint/breakpointwidget.cpp 7337a4e
>
> Diff: http://git.reviewboard.kde.org/r/111779/diff/
>
>
> Testing
> -------
>
> All gdb unit tests are passed.
>
>
> Thanks,
>
> Vlas Puhov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130729/fbd7366e/attachment.html>
More information about the KDevelop-devel
mailing list