Review Request 111779: Breakpoint model: use custom LocationRole for retrieve full path, Qt::DisplayRole for file's name.

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jul 29 14:46:26 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111779/#review36751
-----------------------------------------------------------



debugger/breakpoint/breakpoint.h
<http://git.reviewboard.kde.org/r/111779/#comment27136>

    use Qt::UserRole+1 instead of 33



debugger/breakpoint/breakpoint.cpp
<http://git.reviewboard.kde.org/r/111779/#comment27134>

    Unrelated change, submit it in a different commit



debugger/breakpoint/breakpoint.cpp
<http://git.reviewboard.kde.org/r/111779/#comment27135>

    else if


- Aleix Pol Gonzalez


On July 29, 2013, 2:06 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111779/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 2:06 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> See mail list for details.
> 
> 
> Diffs
> -----
> 
>   debugger/breakpoint/breakpoint.h bc56e46 
>   debugger/breakpoint/breakpoint.cpp 22bdbd0 
>   debugger/breakpoint/breakpointmodel.h ab65d77 
>   debugger/breakpoint/breakpointwidget.h 79453b0 
>   debugger/breakpoint/breakpointwidget.cpp 7337a4e 
> 
> Diff: http://git.reviewboard.kde.org/r/111779/diff/
> 
> 
> Testing
> -------
> 
> All gdb unit tests are passed.
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130729/ca8b0105/attachment.html>


More information about the KDevelop-devel mailing list