Review Request 111155: Install the Grantlee filter into the right location.

Commit Hook null at kde.org
Tue Jul 2 10:34:15 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111155/
-----------------------------------------------------------

(Updated July 2, 2013, 10:34 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop, Miha Čančula and Milian Wolff.


Description
-------

This is similar to what was done to Skrooge in commit 14baa01.

Grantlee plugins, such as kdev_filters, are Qt plugins, and thus it makes
sense to install it into ${PLUGIN_INSTALL_DIR} instead of installing into
the same directory Grantlee uses for its own filters.

It's also worth pointing out that people are expected to have the
QT_PLUGIN_PATH environment variable correctly set for the filter to be
found by Grantlee.


Diffs
-----

  template/CMakeLists.txt 0dfa6586cc183dcc6ac2c2ca3c6df25c8479683d 
  template/filters/CMakeLists.txt 8f590002406352198fe4c6908c6a299c2acfed6c 

Diff: http://git.reviewboard.kde.org/r/111155/diff/


Testing
-------


Thanks,

Raphael Kubo da Costa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130702/f18bcf73/attachment.html>


More information about the KDevelop-devel mailing list