Review Request 111155: Install the Grantlee filter into the right location.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111155/#review35431
-----------------------------------------------------------


This review has been submitted with commit e81313bc8677e2d5f7fa2f69b52098d0845e2dcd by Raphael Kubo da Costa to branch 1.5.

- Commit Hook


On June 20, 2013, 7:06 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111155/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 7:06 p.m.)
> 
> 
> Review request for KDevelop, Miha Čančula and Milian Wolff.
> 
> 
> Description
> -------
> 
> This is similar to what was done to Skrooge in commit 14baa01.
> 
> Grantlee plugins, such as kdev_filters, are Qt plugins, and thus it makes
> sense to install it into ${PLUGIN_INSTALL_DIR} instead of installing into
> the same directory Grantlee uses for its own filters.
> 
> It's also worth pointing out that people are expected to have the
> QT_PLUGIN_PATH environment variable correctly set for the filter to be
> found by Grantlee.
> 
> 
> Diffs
> -----
> 
>   template/CMakeLists.txt 0dfa6586cc183dcc6ac2c2ca3c6df25c8479683d 
>   template/filters/CMakeLists.txt 8f590002406352198fe4c6908c6a299c2acfed6c 
> 
> Diff: http://git.reviewboard.kde.org/r/111155/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130702/f7762a9d/attachment-0001.html>