Review Request 108214: [3/3] Adjust kdev-ninja to EnvironmentSelectionWidget refactor.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108214/#review35383
-----------------------------------------------------------

Ship it!


Removing code, always a good thing™ :) If you tested it as you said, go for it. Thanks!

- Milian Wolff


On June 27, 2013, 12:59 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108214/
> -----------------------------------------------------------
> 
> (Updated June 27, 2013, 12:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> A follow-up to https://git.reviewboard.kde.org/r/108212/ .
> This removes calls to addItems() and uses "" instead of "default" as default config values.
> 
> 
> Diffs
> -----
> 
>   ninjaconfig.ui 520d7be 
>   ninjabuilderpreferences.cpp 02aa353 
>   ninjabuilderconfig.kcfg e1d3c13 
> 
> Diff: http://git.reviewboard.kde.org/r/108214/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130701/045526b4/attachment-0001.html>