Review Request 104574: Memory viewer fixes.

[Ben Wagner]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104574/
-----------------------------------------------------------

(Updated Feb. 7, 2013, 11:04 p.m.)


Review request for KDevelop.


Changes
-------

Makes the memory view a bit more usable and re-enables it.


Description
-------

This is a somewhat odd patch, since it changes what is currently dead code. However, uncommenting the relevant portions of debuggerplugin.* and CMakeLists in debuggers/gdb allows it to be used. This change makes the memory viewer at least work and not crash, which is an improvement over the existing state. This code needs more work before being re-enabled, as does the code which calls it (it is rather strange the way it's UI is set up). However, this is a good checkpoint.


Diffs (updated)
-----

  debuggers/gdb/CMakeLists.txt 021ea33 
  debuggers/gdb/debuggerplugin.h fe12ddd 
  debuggers/gdb/debuggerplugin.cpp d499af1 
  debuggers/gdb/memviewdlg.h 1629cd0 
  debuggers/gdb/memviewdlg.cpp 0500a21 

Diff: http://git.reviewboard.kde.org/r/104574/diff/


Testing
-------

Got it working. Used it. When Okteta is installed it works and I haven't gotten it to crash again yet.


Thanks,

Ben Wagner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130207/f74b76e8/attachment-0001.html>