Review Request 104574: Memory viewer fixes.

Ben Wagner bungeman at gmail.com
Thu Feb 7 22:49:44 UTC 2013



> On Feb. 7, 2013, 10:27 p.m., Kevin Funk wrote:
> > Ben, can you commit?

After https://git.reviewboard.kde.org/r/108814/ I have a better version of this lined up. Will update this review soon.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104574/#review26920
-----------------------------------------------------------


On April 13, 2012, 12:19 a.m., Ben Wagner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104574/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 12:19 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This is a somewhat odd patch, since it changes what is currently dead code. However, uncommenting the relevant portions of debuggerplugin.* and CMakeLists in debuggers/gdb allows it to be used. This change makes the memory viewer at least work and not crash, which is an improvement over the existing state. This code needs more work before being re-enabled, as does the code which calls it (it is rather strange the way it's UI is set up). However, this is a good checkpoint.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/memviewdlg.h 1629cd0 
>   debuggers/gdb/memviewdlg.cpp 0500a21 
> 
> Diff: http://git.reviewboard.kde.org/r/104574/diff/
> 
> 
> Testing
> -------
> 
> Got it working. Used it. When Okteta is installed it works and I haven't gotten it to crash again yet.
> 
> 
> Thanks,
> 
> Ben Wagner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130207/19295e06/attachment-0001.html>


More information about the KDevelop-devel mailing list