Review Request 108482: Title bar now correctly updades after Open/Import or Close Project

[Lambert CLARA]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108482/
-----------------------------------------------------------

(Updated April 1, 2013, 1:04 p.m.)


Review request for KDevelop.


Changes
-------

Update patch according to the comments :
- The updateContainedProjects method now only exist in Session class
- Use a qobject_cast to be sure that the ISession pointer we got is indeed of Session type
- Remove the "virtual" keyword on the overridden methods
- Remove the spaces changes

PS: Sorry for the lag :)


Description
-------

On a newly created session, the mainwindow name remained at (no projects) after an Open/Import project, and was not updated when a project was closed.
If kdevelop was opened with an already existing session, the title bar was ok.

This was due to the SessionInfo's project list, which was not updated when loading/closing a project. However, the config group was, explaining why it worked at reboot.


Diffs (updated)
-----

  shell/projectcontroller.cpp 56a65bc 
  shell/session.h d47ec41 
  shell/session.cpp a59d70e 

Diff: http://git.reviewboard.kde.org/r/108482/diff/


Testing
-------

Open/Import multiple projects on a newly created session, and close them. Open multiple instances of kdevelop and do the same.
Launch ctest, 100% tests passed, 0 tests failed out of 43.


Thanks,

Lambert CLARA

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130401/ed83f155/attachment.html>