<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108482/">http://git.reviewboard.kde.org/r/108482/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Lambert CLARA.</div>
<p style="color: grey;"><i>Updated April 1, 2013, 1:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Update patch according to the comments :
- The updateContainedProjects method now only exist in Session class
- Use a qobject_cast to be sure that the ISession pointer we got is indeed of Session type
- Remove the "virtual" keyword on the overridden methods
- Remove the spaces changes
PS: Sorry for the lag :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On a newly created session, the mainwindow name remained at (no projects) after an Open/Import project, and was not updated when a project was closed.
If kdevelop was opened with an already existing session, the title bar was ok.
This was due to the SessionInfo's project list, which was not updated when loading/closing a project. However, the config group was, explaining why it worked at reboot.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Open/Import multiple projects on a newly created session, and close them. Open multiple instances of kdevelop and do the same.
Launch ctest, 100% tests passed, 0 tests failed out of 43.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/projectcontroller.cpp <span style="color: grey">(56a65bc)</span></li>
<li>shell/session.h <span style="color: grey">(d47ec41)</span></li>
<li>shell/session.cpp <span style="color: grey">(a59d70e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108482/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>