Review Request 108482: Title bar now correctly updades after Open/Import or Close Project

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108482/#review30302
-----------------------------------------------------------



shell/projectcontroller.cpp
<http://git.reviewboard.kde.org/r/108482/#comment22549>

    You are always calling the new method after saveListOfOpenedProjects, maybe you should call it from there?



shell/session.cpp
<http://git.reviewboard.kde.org/r/108482/#comment22550>

    This method can be a slot and be called after projectClosed/projectOpened. This way we wouldn't need to put specific code in the ProjectController.


- Aleix Pol Gonzalez


On April 1, 2013, 11:04 a.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108482/
> -----------------------------------------------------------
> 
> (Updated April 1, 2013, 11:04 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> On a newly created session, the mainwindow name remained at (no projects) after an Open/Import project, and was not updated when a project was closed.
> If kdevelop was opened with an already existing session, the title bar was ok.
> 
> This was due to the SessionInfo's project list, which was not updated when loading/closing a project. However, the config group was, explaining why it worked at reboot.
> 
> 
> Diffs
> -----
> 
>   shell/projectcontroller.cpp 56a65bc 
>   shell/session.h d47ec41 
>   shell/session.cpp a59d70e 
> 
> Diff: http://git.reviewboard.kde.org/r/108482/diff/
> 
> 
> Testing
> -------
> 
> Open/Import multiple projects on a newly created session, and close them. Open multiple instances of kdevelop and do the same.
> Launch ctest, 100% tests passed, 0 tests failed out of 43.
> 
> 
> Thanks,
> 
> Lambert CLARA
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130403/2ef11a2f/attachment.html>