Review Request: kdevelop: Adjust CMake for project KCM selection semantic change.

[Aleix Pol Gonzalez]

> On Sept. 22, 2012, 2:13 p.m., Milian Wolff wrote:
> > projectbuilders/cmakebuilder/kdevcmakebuilder.desktop, line 119
> > <http://git.reviewboard.kde.org/r/106513/diff/1/?file=86419#file86419line119>
> >
> >     just to make sure: nowhere in the cmake plugin we blindly assume that the makebuilder plugin is available? if so, this change is valid
> >     
> >     but generally, it's a bit odd I think - couldn't it now happen that neither the ninja nor the make builder plugins are loaded?
> 
> Ivan Shapovalov wrote:
>     No, it does not take such an assumption (though the cmake builder queries plugins in order to find make/ninja builder, but everything is guarded there).
>     OTOH, CMake won't be much usable without a secondary builder, and since make builder is the only one built in KDevelop, we may want it loaded...
>     
>     Anyway, let Aleix comment on it.

No, we're not using make for anything in CMakeManager, we're in the previous step. CMakeBuilder now uses MakeBuilder if it's a make build directory. It might happen that the user would disable the compilation of the MakeBuilder, but... I don't see a reason for that, honestly.

It has happened some times that a user didn't have the MakeBuilder but it was only cases where it was wrongly installed.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106513/#review19299
-----------------------------------------------------------


On Sept. 20, 2012, 3:54 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106513/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2012, 3:54 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> Adjust CMake project manager/builder for this review: https://git.reviewboard.kde.org/r/106512/.
> This gets rid of an unused interface requirement IMakeBuilder and implements the IBuildSystemManager::additionalBuilderPlugins() method returning either Make or Ninja builder, whatever is appropriate for the given project.
> 
> 
> Diffs
> -----
> 
>   projectbuilders/cmakebuilder/cmakebuilder.h 1f67e6a 
>   projectbuilders/cmakebuilder/kdevcmakebuilder.desktop 819bca0 
>   projectmanagers/cmake/cmakemanager.h 65520bf 
>   projectmanagers/cmake/cmakemanager.cpp fa05061 
> 
> Diff: http://git.reviewboard.kde.org/r/106513/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests and manual testing on both cmake+ninja and cmake+make projects (as well as on non-cmake ones).
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120922/e13c44da/attachment.html>