Review Request: kdevelop: Adjust CMake for project KCM selection semantic change.
Ivan Shapovalov
intelfx100 at gmail.com
Sat Sep 22 21:29:30 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106513/
-----------------------------------------------------------
(Updated Sept. 22, 2012, 9:29 p.m.)
Review request for KDevelop and Aleix Pol Gonzalez.
Changes
-------
- Left "X-KDevelop-IRequired" in the cmake builder as it is
- Adjusted for the interface change in parent review
Description (updated)
-------
Adjust CMake project builder for this review: https://git.reviewboard.kde.org/r/106512/.
This implements the IProjectBuilder::additionalBuilderPlugins() method returning either Make or Ninja builder, whatever is appropriate for the given project.
Diffs (updated)
-----
projectbuilders/cmakebuilder/cmakebuilder.h 1f67e6a
projectbuilders/cmakebuilder/cmakebuilder.cpp 2ad9d74
Diff: http://git.reviewboard.kde.org/r/106513/diff/
Testing
-------
Existing unit-tests and manual testing on both cmake+ninja and cmake+make projects (as well as on non-cmake ones).
Thanks,
Ivan Shapovalov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120922/d3419118/attachment.html>
More information about the KDevelop-devel
mailing list