<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106513/">http://git.reviewboard.kde.org/r/106513/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 22nd, 2012, 2:13 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106513/diff/1/?file=86419#file86419line119" style="color: black; font-weight: bold; text-decoration: underline;">projectbuilders/cmakebuilder/kdevcmakebuilder.desktop</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">119</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">X-KDevelop-IRequired=org.kdevelop.IOutputView<span class="hl">,org.kdevelop.IMakeBuilder</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">119</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">X-KDevelop-IRequired=org.kdevelop.IOutputView</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just to make sure: nowhere in the cmake plugin we blindly assume that the makebuilder plugin is available? if so, this change is valid
but generally, it's a bit odd I think - couldn't it now happen that neither the ninja nor the make builder plugins are loaded?</pre>
</blockquote>
<p>On September 22nd, 2012, 2:35 p.m., <b>Ivan Shapovalov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, it does not take such an assumption (though the cmake builder queries plugins in order to find make/ninja builder, but everything is guarded there).
OTOH, CMake won't be much usable without a secondary builder, and since make builder is the only one built in KDevelop, we may want it loaded...
Anyway, let Aleix comment on it.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, we're not using make for anything in CMakeManager, we're in the previous step. CMakeBuilder now uses MakeBuilder if it's a make build directory. It might happen that the user would disable the compilation of the MakeBuilder, but... I don't see a reason for that, honestly.
It has happened some times that a user didn't have the MakeBuilder but it was only cases where it was wrongly installed.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 20th, 2012, 3:54 p.m., Ivan Shapovalov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Ivan Shapovalov.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2012, 3:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adjust CMake project manager/builder for this review: https://git.reviewboard.kde.org/r/106512/.
This gets rid of an unused interface requirement IMakeBuilder and implements the IBuildSystemManager::additionalBuilderPlugins() method returning either Make or Ninja builder, whatever is appropriate for the given project.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Existing unit-tests and manual testing on both cmake+ninja and cmake+make projects (as well as on non-cmake ones).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectbuilders/cmakebuilder/cmakebuilder.h <span style="color: grey">(1f67e6a)</span></li>
<li>projectbuilders/cmakebuilder/kdevcmakebuilder.desktop <span style="color: grey">(819bca0)</span></li>
<li>projectmanagers/cmake/cmakemanager.h <span style="color: grey">(65520bf)</span></li>
<li>projectmanagers/cmake/cmakemanager.cpp <span style="color: grey">(fa05061)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106513/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>