Review Request: BuilderJob: (eye-candy) flatten composite job hierarchies and generate a meaningful job name

Ivan Shapovalov intelfx100 at
Sat Sep 22 16:21:13 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 22, 2012, 4:21 p.m.)

Review request for KDevelop.


- Use QVector instead of a QList to store job metadata
- Use QList instead of a QSet to store build actions while generating job's name: this helps to preserve actions ordering and not to have something like "build, configure, install" in job name.

Notice: hunks which call updateJobName() where it is needed are included in this review, so it is dependent on


1. If a BuilderJob is added into another BuilderJob, the latter's subjobs are inserted into the former rather than having two nested composite jobs.
2. A BuilderJob has its name generated from its contents (this is real eye-candy).

Diffs (updated)

  plugins/execute/executeplugin.cpp 817c082 
  plugins/projectmanagerview/projectmanagerviewplugin.cpp 968376d 
  project/builderjob.h 297f187 
  project/builderjob.cpp 44519d3 



Existing unit-tests, various hand-testing.


Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list