Review Request: BuilderJob: (eye-candy) flatten composite job hierarchies and generate a meaningful job name
Aleix Pol Gonzalez
aleixpol at gmail.com
Sat Sep 22 18:32:41 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106461/#review19322
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Sept. 22, 2012, 4:21 p.m., Ivan Shapovalov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106461/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2012, 4:21 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> 1. If a BuilderJob is added into another BuilderJob, the latter's subjobs are inserted into the former rather than having two nested composite jobs.
> 2. A BuilderJob has its name generated from its contents (this is real eye-candy).
>
>
> Diffs
> -----
>
> plugins/execute/executeplugin.cpp 817c082
> plugins/projectmanagerview/projectmanagerviewplugin.cpp 968376d
> project/builderjob.h 297f187
> project/builderjob.cpp 44519d3
>
> Diff: http://git.reviewboard.kde.org/r/106461/diff/
>
>
> Testing
> -------
>
> Existing unit-tests, various hand-testing.
>
>
> Thanks,
>
> Ivan Shapovalov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120922/688c95af/attachment.html>
More information about the KDevelop-devel
mailing list