Review Request: BuilderJob: (eye-candy) flatten composite job hierarchies and generate a meaningful job name

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106461/#review19302
-----------------------------------------------------------

Ship it!


OK from my side, with the exception of the QList-choice.

Regarding updateName: it's ugly, I agree, but I don't see a better way...


project/builderjob.h
<http://git.reviewboard.kde.org/r/106461/#comment15281>

    use QVector please


- Milian Wolff


On Sept. 17, 2012, 7:51 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106461/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 7:51 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> 1. If a BuilderJob is added into another BuilderJob, the latter's subjobs are inserted into the former rather than having two nested composite jobs.
> 2. A BuilderJob has its name generated from its contents (this is real eye-candy).
> 
> 
> Diffs
> -----
> 
>   plugins/execute/executeplugin.cpp 817c082 
>   plugins/projectmanagerview/projectmanagerviewplugin.cpp 968376d 
>   project/builderjob.h 297f187 
>   project/builderjob.cpp 44519d3 
> 
> Diff: http://git.reviewboard.kde.org/r/106461/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests, various hand-testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120922/7a28bc44/attachment.html>