Review Request: (code deduplication) Add class OutputExecuteJob as a common base for all output jobs which start processes

[Ivan Shapovalov]

> On Sept. 17, 2012, 11:37 a.m., Aleix Pol Gonzalez wrote:
> > outputview/outputexecutejob.cpp, line 402
> > <http://git.reviewboard.kde.org/r/106463/diff/1/?file=85697#file85697line402>
> >
> >     This should be called when the arguments change as well, then.
> 
> Ivan Shapovalov wrote:
>     Ok - but only if "AppendProcessString" is set.

Actually no, if we're going to leave both setters and virtual functions. One shall just call ::setJobName() after the arguments are ready (as stated in the comment); otherwise, one would get different semantics when using operator<<() and overriding ::commandLine().


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106463/#review19055
-----------------------------------------------------------


On Sept. 17, 2012, 9:21 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106463/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 9:21 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This class is going to be used instead of OutputJob as a common base for all such jobs which start processes (esp., builder jobs).
> 
> There are separate patches for make builder, cmake job and ninja builder.
> 
> 
> Diffs
> -----
> 
>   outputview/CMakeLists.txt 3dced4c 
>   outputview/outputexecutejob.h PRE-CREATION 
>   outputview/outputexecutejob.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106463/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests and manual testing (couple of days).
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120919/b33cdb35/attachment.html>