Review Request: (code deduplication) Add class OutputExecuteJob as a common base for all output jobs which start processes

[Ivan Shapovalov]

On Sept. 17, 2012, 11:37 a.m., Ivan Shapovalov wrote:
> > Well, as I've slightly discussed in my comments, we probably would need to restrict the scope of this class to builders, but maybe not. I haven't seen this but the code that will be shared is not this much and I'm a bit afraid we could lose some semantics here and there, in terms of feedback to the user.
> > 
> > OTOH, I'm always in for some code removal :). Let's work it out a bit further.

About virtual functions and setters: someone would prefer to reimplement virtual functions, and for someone it would be simpler to use setters (for example, if all arguments are historically passed to the ctor).
Does it hurt that much to have both virtual functions and private fields + setters as a default implementation?


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106463/#review19055
-----------------------------------------------------------


On Sept. 17, 2012, 9:21 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106463/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 9:21 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This class is going to be used instead of OutputJob as a common base for all such jobs which start processes (esp., builder jobs).
> 
> There are separate patches for make builder, cmake job and ninja builder.
> 
> 
> Diffs
> -----
> 
>   outputview/CMakeLists.txt 3dced4c 
>   outputview/outputexecutejob.h PRE-CREATION 
>   outputview/outputexecutejob.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106463/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests and manual testing (couple of days).
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120917/c9d69dfc/attachment.html>