Review Request: Fix stale suffix text removal in (and refactor) SIGNAL()/SLOT() completion.

[Ivan Shapovalov]

> On Sept. 16, 2012, 10:26 p.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 3
> > <http://git.reviewboard.kde.org/r/106451/diff/1/?file=85494#file85494line3>
> >
> >     This shouldn't be in that patch :)

Ugh, sorry :) I'm having tests switched off in the release build so it doesn't take too long on my Atom..


> On Sept. 16, 2012, 10:26 p.m., Aleix Pol Gonzalez wrote:
> > languages/cpp/codecompletion/item.cpp, line 149
> > <http://git.reviewboard.kde.org/r/106451/diff/1/?file=85495#file85495line149>
> >
> >     Aren't you making it a bit too complicated?
> >     You wont have the nesting > 1 in any case...

About nesting counting at all: it is needed since there can be anything in the sig/slot parameters, including function pointers and who knows what else.
About "lineSuffixAndWord" instead of just "lineSuffix": that's just a generalization; if using only line suffix, we'd have to manually account for opening bracket...


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106451/#review19043
-----------------------------------------------------------


On Sept. 15, 2012, 10:14 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106451/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2012, 10:14 a.m.)
> 
> 
> Review request for KDevelop and Olivier Jean de Gaalon.
> 
> 
> Description
> -------
> 
> Most notably, I stopped using a complicated regex for detecting
> pieces of stale SIGNAL()/SLOT() macros like in
> "SIGNAL( <cursor here> someOldStuff(withArguments) )".
> Instead, just delete everything from cursor to next
> statement delimiter or EOL or unrelated closing bracket.
> 
> Also, added extensive comments on what's being done
> as the code was pretty unclear.
> 
> 
> This addresses bugs 202135 and 224996.
>     http://bugs.kde.org/show_bug.cgi?id=202135
>     http://bugs.kde.org/show_bug.cgi?id=224996
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 55bbd1a 
>   languages/cpp/codecompletion/item.cpp d52c832 
> 
> Diff: http://git.reviewboard.kde.org/r/106451/diff/
> 
> 
> Testing
> -------
> 
> Manual testing using examples provided in the bug-reports; existing unit-tests pass.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120917/236ce8dc/attachment.html>