Review Request: Fix stale suffix text removal in (and refactor) SIGNAL()/SLOT() completion.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106451/#review19043
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/106451/#comment15115>

    This shouldn't be in that patch :)



languages/cpp/codecompletion/item.cpp
<http://git.reviewboard.kde.org/r/106451/#comment15116>

    Aren't you making it a bit too complicated?
    You wont have the nesting > 1 in any case...


I won't give you the shipit anyway because I haven't worked with this code before, so I'd prefer if Olivier, David or Milian can give their opinion about this.

I must say though, that I'm really happy to see someone caring about it since it's something important for us that needs some attention it hasn't received for a while and is clearly problematic. I've had to fix this code generation by hand many times, and I'm sure most of our users who use Qt have as well, so thanks!

- Aleix Pol Gonzalez


On Sept. 15, 2012, 10:14 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106451/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2012, 10:14 a.m.)
> 
> 
> Review request for KDevelop and Olivier Jean de Gaalon.
> 
> 
> Description
> -------
> 
> Most notably, I stopped using a complicated regex for detecting
> pieces of stale SIGNAL()/SLOT() macros like in
> "SIGNAL( <cursor here> someOldStuff(withArguments) )".
> Instead, just delete everything from cursor to next
> statement delimiter or EOL or unrelated closing bracket.
> 
> Also, added extensive comments on what's being done
> as the code was pretty unclear.
> 
> 
> This addresses bugs 202135 and 224996.
>     http://bugs.kde.org/show_bug.cgi?id=202135
>     http://bugs.kde.org/show_bug.cgi?id=224996
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 55bbd1a 
>   languages/cpp/codecompletion/item.cpp d52c832 
> 
> Diff: http://git.reviewboard.kde.org/r/106451/diff/
> 
> 
> Testing
> -------
> 
> Manual testing using examples provided in the bug-reports; existing unit-tests pass.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120916/f92b47a0/attachment.html>