Review Request: Fix stale suffix text removal in (and refactor) SIGNAL()/SLOT() completion.

[Ivan Shapovalov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106451/
-----------------------------------------------------------

(Updated Sept. 17, 2012, 4:17 a.m.)


Review request for KDevelop and Olivier Jean de Gaalon.


Changes
-------

Removed unrelated changes.


Description
-------

Most notably, I stopped using a complicated regex for detecting
pieces of stale SIGNAL()/SLOT() macros like in
"SIGNAL( <cursor here> someOldStuff(withArguments) )".
Instead, just delete everything from cursor to next
statement delimiter or EOL or unrelated closing bracket.

Also, added extensive comments on what's being done
as the code was pretty unclear.


This addresses bugs 202135 and 224996.
    http://bugs.kde.org/show_bug.cgi?id=202135
    http://bugs.kde.org/show_bug.cgi?id=224996


Diffs (updated)
-----

  languages/cpp/codecompletion/item.cpp d52c832 

Diff: http://git.reviewboard.kde.org/r/106451/diff/


Testing
-------

Manual testing using examples provided in the bug-reports; existing unit-tests pass.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120917/58343eb4/attachment.html>