Review Request: Fix stale suffix text removal in (and refactor) SIGNAL()/SLOT() completion.

Ivan Shapovalov intelfx100 at
Mon Sep 17 04:17:49 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 17, 2012, 4:17 a.m.)

Review request for KDevelop and Olivier Jean de Gaalon.


Removed unrelated changes.


Most notably, I stopped using a complicated regex for detecting
pieces of stale SIGNAL()/SLOT() macros like in
"SIGNAL( <cursor here> someOldStuff(withArguments) )".
Instead, just delete everything from cursor to next
statement delimiter or EOL or unrelated closing bracket.

Also, added extensive comments on what's being done
as the code was pretty unclear.

This addresses bugs 202135 and 224996.

Diffs (updated)

  languages/cpp/codecompletion/item.cpp d52c832 



Manual testing using examples provided in the bug-reports; existing unit-tests pass.


Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list