Review Request: Cleanup "~/.cache/kdevduchain/<session>" on session remove (+refactor allocateRepository()).

[Ivan Shapovalov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106945/
-----------------------------------------------------------

(Updated Oct. 29, 2012, 2:19 p.m.)


Review request for KDevelop and Milian Wolff.


Changes
-------

Rebase, change path to .cache/kdevduchain, cleanup.


Summary (updated)
-----------------

Cleanup "~/.cache/kdevduchain/<session>" on session remove (+refactor allocateRepository()).


Description (updated)
-------

1. Clean (rmdir) the per-session duchain store on session removal (particularly useful in unit-tests and their temporary sessions).
2. Partially refactor allocateRepository() (separate cache path compution into a different function, fix formatting, handle lockfiles properly)

Don't know if I've done that properly, but I wanted to avoid mentioning ".cache/kdevduchain" in two unrelated places.


Diffs (updated)
-----

  language/duchain/repositories/itemrepository.h 392847c 
  language/duchain/repositories/itemrepository.cpp 8d559cf 
  shell/session.cpp a59d70e 

Diff: http://git.reviewboard.kde.org/r/106945/diff/


Testing
-------

Existing unit-tests and manual testing.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121029/8a1a3ff4/attachment.html>