Review Request: Add ordering to the project build set.
Ivan Shapovalov
intelfx100 at gmail.com
Fri Oct 19 17:39:13 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106954/
-----------------------------------------------------------
Review request for KDevelop.
Description
-------
The ordering is provided by adding another list, m_orderingCache, to the model.
It is stored per-session and contains all elements that were added to the model (even from unloaded projects). An element is removed from the ordering cache when and only when user removes it from the model by hand.
When an element is added into the model, it is firstly looked up in the ordering cache to determine its position and, if found, it is inserted into a corresponding position.
If not, the element is appended to both the model and the cache.
Diffs
-----
project/projectbuildsetmodel.h c37f6af
project/projectbuildsetmodel.cpp 67deb30
shell/projectcontroller.cpp 13afff0
Diff: http://git.reviewboard.kde.org/r/106954/diff/
Testing
-------
Manual and existing unit-tests.
Do we need new unit-tests for this? If yes (and if everything else is accepted), I'll write tests.
Thanks,
Ivan Shapovalov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121019/d26354bd/attachment.html>
More information about the KDevelop-devel
mailing list