Review Request: Cleanup "~/.kdevduchain/<session>" on session remove (+refactor allocateRepository()).

Ivan Shapovalov intelfx100 at gmail.com
Fri Oct 19 17:33:24 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106945/
-----------------------------------------------------------

Review request for KDevelop and Milian Wolff.


Description
-------

1. Clean (rmdir) the per-session duchain store on session removal (particularly useful in unit-tests and their temporary sessions).
2. Partially refactor allocateRepository() (separate cache path compution into a different function, fix formatting, handle lockfiles properly)

Don't know if I've done that properly, but I wanted to avoid mentioning ".kdevduchain" in two unrelated places.


Diffs
-----

  language/duchain/repositories/itemrepository.h 091af45 
  language/duchain/repositories/itemrepository.cpp 3bce5d7 
  shell/session.cpp d641b04 

Diff: http://git.reviewboard.kde.org/r/106945/diff/


Testing
-------

Existing unit-tests and manual testing.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121019/182fb59c/attachment.html>


More information about the KDevelop-devel mailing list