Review Request: (code deduplication) Add class OutputExecuteJob as a common base for all output jobs which start processes

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106463/#review19696
-----------------------------------------------------------


Two minor issues, then I'm all for it.


outputview/outputexecutejob.h
<http://git.reviewboard.kde.org/r/106463/#comment15667>

    please use Q_PRIVATE_SLOT in public, pimpled API



outputview/outputexecutejob.cpp
<http://git.reviewboard.kde.org/r/106463/#comment15668>

    this shouldn't be sorted, should it? then use QHash as that's faster.


- Milian Wolff


On Sept. 27, 2012, 4:35 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106463/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2012, 4:35 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This class is going to be used instead of OutputJob as a common base for all such jobs which start processes (esp., builder jobs).
> 
> There are separate patches for make builder, cmake job and ninja builder.
> 
> 
> Diffs
> -----
> 
>   outputview/CMakeLists.txt 3dced4c 
>   outputview/outputexecutejob.h PRE-CREATION 
>   outputview/outputexecutejob.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106463/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests and manual testing (couple of days).
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121001/0953fcc3/attachment.html>