Review Request: OpenWith - configuration dialog

[Milian Wolff]

> On Oct. 25, 2012, 9:25 p.m., Milian Wolff wrote:
> > note: this patch was actually leaking the config dialog, I've fixed that now and cleaned up the whole plugin as well
> > 
> > cheers, many thanks.

hm actually looking at the stuff a bit more, I think I'll remove the config dialog again and simplify the ui a bit such that it should be more straight forward and not require a config dialog...

sorry to have wasted your time and thanks for your contribution anyways. try to review my changes afterwards, maybe you learn something or have suggestions :)

cheers


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106388/#review20925
-----------------------------------------------------------


On Oct. 17, 2012, 12:43 p.m., Przemek Czekaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106388/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2012, 12:43 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Added a configuration dialog to the context menu.
> 
> @edit
> give me few days, I will improve patch.
> 
> 
> This addresses bug 287764.
>     http://bugs.kde.org/show_bug.cgi?id=287764
> 
> 
> Diffs
> -----
> 
>   plugins/openwith/CMakeLists.txt 8742aeb 
>   plugins/openwith/openwithconfig.h PRE-CREATION 
>   plugins/openwith/openwithconfig.cpp PRE-CREATION 
>   plugins/openwith/openwithconfig.ui PRE-CREATION 
>   plugins/openwith/openwithplugin.h 809a0e8 
>   plugins/openwith/openwithplugin.cpp 69404ef 
> 
> Diff: http://git.reviewboard.kde.org/r/106388/diff/
> 
> 
> Testing
> -------
> 
> Compiled, and local install. Tested by hand.
> 
> 
> Screenshots
> -----------
> 
> OpenWith context menu
>   http://git.reviewboard.kde.org/r/106388/s/722/
> Openwith dialog - internal option
>   http://git.reviewboard.kde.org/r/106388/s/723/
> Open with - selectable list
>   http://git.reviewboard.kde.org/r/106388/s/724/
> 
> 
> Thanks,
> 
> Przemek Czekaj
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121025/4fa1d9ba/attachment.html>