Review Request: (code deduplication) Add class OutputExecuteJob as a common base for all output jobs which start processes
Ivan Shapovalov
intelfx100 at gmail.com
Tue Oct 2 10:44:27 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106463/
-----------------------------------------------------------
(Updated Oct. 2, 2012, 10:44 a.m.)
Review request for KDevelop.
Changes
-------
Fixed two minor issues and a major bug in flag enums usage.
Description
-------
This class is going to be used instead of OutputJob as a common base for all such jobs which start processes (esp., builder jobs).
There are separate patches for make builder, cmake job and ninja builder.
Diffs (updated)
-----
outputview/CMakeLists.txt 3dced4c
outputview/outputexecutejob.h PRE-CREATION
outputview/outputexecutejob.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/106463/diff/
Testing
-------
Existing unit-tests and manual testing (couple of days).
Thanks,
Ivan Shapovalov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121002/8c396f6e/attachment.html>
More information about the KDevelop-devel
mailing list