Review Request: Correct output dir property initialization

Sergey Vidyuk sir.vestnik at gmail.com
Thu Nov 29 20:36:18 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107522/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

RUNTIME_OUTPUT_DIRECTORY and LIBRARY_OUTPUT_DIRECTORY target properties are
initialized by default with CMAKE_(RUNTIME|LIBRARY)_OUTPUT_DIRECTORY
variables. This comit adds same behaviour to the CMakeProjectVisitor

This allows to add working launcher configuration for executable targets
in a project with customized CMAKE_RUNTIME_OUTPUT_DIRECTORY value.


Diffs
-----

  projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 9d5826d 
  projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.h 9e95426 
  projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.cpp 3c750f0 

Diff: http://git.reviewboard.kde.org/r/107522/diff/


Testing
-------

 * Run unit tests added in the commit
 * Manually tested launchers for targets on a project which put all its executable targets into ${CMAKE_BUILD_DIR}/bin


Thanks,

Sergey Vidyuk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121129/b2572c33/attachment.html>


More information about the KDevelop-devel mailing list