Review Request: Correct output dir property initialization

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107522/#review22800
-----------------------------------------------------------

Ship it!


That's a very interesting work that you're doing :) very appreciated!

PS: can you maybe get a git account? it can be useful

- Aleix Pol Gonzalez


On Nov. 29, 2012, 8:36 p.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107522/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2012, 8:36 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> RUNTIME_OUTPUT_DIRECTORY and LIBRARY_OUTPUT_DIRECTORY target properties are
> initialized by default with CMAKE_(RUNTIME|LIBRARY)_OUTPUT_DIRECTORY
> variables. This comit adds same behaviour to the CMakeProjectVisitor
> 
> This allows to add working launcher configuration for executable targets
> in a project with customized CMAKE_RUNTIME_OUTPUT_DIRECTORY value.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 9d5826d 
>   projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.h 9e95426 
>   projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.cpp 3c750f0 
> 
> Diff: http://git.reviewboard.kde.org/r/107522/diff/
> 
> 
> Testing
> -------
> 
>  * Run unit tests added in the commit
>  * Manually tested launchers for targets on a project which put all its executable targets into ${CMAKE_BUILD_DIR}/bin
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121130/8686c248/attachment.html>