Review Request: Remove duplicated code in project visitor tests

Aleix Pol Gonzalez aleixpol at gmail.com
Fri Nov 30 00:51:50 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107519/#review22801
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 29, 2012, 6:24 p.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107519/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2012, 6:24 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Move common initialization code out from tests themself and reuse same
> code for same logick.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.h 9e95426 
>   projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.cpp 3c750f0 
> 
> Diff: http://git.reviewboard.kde.org/r/107519/diff/
> 
> 
> Testing
> -------
> 
> Run modified tests
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121130/c600a85c/attachment.html>


More information about the KDevelop-devel mailing list