Review Request: Framework for json tests [Attn. lang maintainers]

Olivier Jean de Gaalon olivier.jg at gmail.com
Wed Nov 28 16:02:32 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107489/
-----------------------------------------------------------

(Updated Nov. 28, 2012, 4:02 p.m.)


Review request for KDevelop.


Changes
-------

Fixed Issues.


Description
-------

This patch provides a framework to allow creating json tests for arbitrary objects.
In particular, this allows declarations to be tested using a simple DUChainVisitor (also included) which extracts json data from the declaration's comments and runs the tests specified therein.
This can be used for any language (see kdevelop patch for cpp's implementation).

Please pay special attention to cmake stuff when reviewing because I have no idea what I'm doing.

Why not C++11?
> We don't support it in KDevelop yet.

Why not Boost?
> NIH

Why do the json test functions need to be included instead of linked in?
> Because you'll add your own tests, which will be added to a different instantiation of TestSuite than the provided ones because they come from another library. C++11 might help here with the export keyword, but it's not really important.


Diffs (updated)
-----

  tests/CMakeLists.txt 4a306a4 
  tests/json/CMakeLists.txt PRE-CREATION 
  tests/json/declarationvalidator.h PRE-CREATION 
  tests/json/declarationvalidator.cpp PRE-CREATION 
  tests/json/delayedoutput.h PRE-CREATION 
  tests/json/delayedoutput.cpp PRE-CREATION 
  tests/json/jsondeclarationtests.h PRE-CREATION 
  tests/json/jsonducontexttests.h PRE-CREATION 
  tests/json/jsontesthelpers.h PRE-CREATION 
  tests/json/jsontypetests.h PRE-CREATION 
  tests/json/testsuite.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107489/diff/


Testing
-------

Who tests the testers?


Thanks,

Olivier Jean de Gaalon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121128/607605f3/attachment.html>


More information about the KDevelop-devel mailing list