Review Request: Framework for json tests [Attn. lang maintainers]

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107489/#review22748
-----------------------------------------------------------

Ship it!


Small CMake change is required, then this is OK to be shipped.

Though if possible, please also change the include guards of the header files, especially the exported ones. Imo TESTSUITE_H is too generic for a library header. Rather, I suggest prefixing them with e.g. KDEV_JSONTEST_ or similar - could you please do that as well? Then just commit this stuff.

Great work, thanks Olivier!


tests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107489/#comment17382>

    I'd now move this check into the central CMakeLists.txt along with the macro_log_feature line from plugins/CMakeLists.txt, then only keep the if(QJSON_FOUND) conditionals in the sub-CMakeLists.txt



tests/json/CMakeLists.txt
<http://git.reviewboard.kde.org/r/107489/#comment17383>

    this is not required here (it was already required farther up in the cmake hierarchy)


- Milian Wolff


On Nov. 28, 2012, 4:02 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107489/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2012, 4:02 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch provides a framework to allow creating json tests for arbitrary objects.
> In particular, this allows declarations to be tested using a simple DUChainVisitor (also included) which extracts json data from the declaration's comments and runs the tests specified therein.
> This can be used for any language (see kdevelop patch for cpp's implementation).
> 
> Please pay special attention to cmake stuff when reviewing because I have no idea what I'm doing.
> 
> Why not C++11?
> > We don't support it in KDevelop yet.
> 
> Why not Boost?
> > NIH
> 
> Why do the json test functions need to be included instead of linked in?
> > Because you'll add your own tests, which will be added to a different instantiation of TestSuite than the provided ones because they come from another library. C++11 might help here with the export keyword, but it's not really important.
> 
> 
> Diffs
> -----
> 
>   tests/CMakeLists.txt 4a306a4 
>   tests/json/CMakeLists.txt PRE-CREATION 
>   tests/json/declarationvalidator.h PRE-CREATION 
>   tests/json/declarationvalidator.cpp PRE-CREATION 
>   tests/json/delayedoutput.h PRE-CREATION 
>   tests/json/delayedoutput.cpp PRE-CREATION 
>   tests/json/jsondeclarationtests.h PRE-CREATION 
>   tests/json/jsonducontexttests.h PRE-CREATION 
>   tests/json/jsontesthelpers.h PRE-CREATION 
>   tests/json/jsontypetests.h PRE-CREATION 
>   tests/json/testsuite.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107489/diff/
> 
> 
> Testing
> -------
> 
> Who tests the testers?
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121129/36649c68/attachment.html>