Review Request: Framework for json tests [Attn. lang maintainers]

[Milian Wolff]

> On Nov. 28, 2012, 12:56 p.m., Milian Wolff wrote:
> > Hey Olivier - this is looking really nice as usual :)
> > 
> > I've added some nitpicks here and there, but esp. the JSON stuff should imo be optional, i.e. only when QJSON was found. The rest should be straight forward I think.
> > 
> > Cheers!

Btw: Who reviews the reviewers? :)

And regarding C++11 - what would simplify, besides exporting the templates, when you could have used C++11?


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107489/#review22694
-----------------------------------------------------------


On Nov. 27, 2012, 1:41 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107489/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2012, 1:41 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch provides a framework to allow creating json tests for arbitrary objects.
> In particular, this allows declarations to be tested using a simple DUChainVisitor (also included) which extracts json data from the declaration's comments and runs the tests specified therein.
> This can be used for any language (see kdevelop patch for cpp's implementation).
> 
> Please pay special attention to cmake stuff when reviewing because I have no idea what I'm doing.
> 
> Why not C++11?
> > We don't support it in KDevelop yet.
> 
> Why not Boost?
> > NIH
> 
> Why do the json test functions need to be included instead of linked in?
> > Because you'll add your own tests, which will be added to a different instantiation of TestSuite than the provided ones because they come from another library. C++11 might help here with the export keyword, but it's not really important.
> 
> 
> Diffs
> -----
> 
>   tests/CMakeLists.txt 4a306a4 
>   tests/json/CMakeLists.txt PRE-CREATION 
>   tests/json/declarationvalidator.h PRE-CREATION 
>   tests/json/declarationvalidator.cpp PRE-CREATION 
>   tests/json/delayedoutput.h PRE-CREATION 
>   tests/json/delayedoutput.cpp PRE-CREATION 
>   tests/json/jsondeclarationtests.h PRE-CREATION 
>   tests/json/jsonducontexttests.h PRE-CREATION 
>   tests/json/jsontesthelpers.h PRE-CREATION 
>   tests/json/jsontypetests.h PRE-CREATION 
>   tests/json/testsuite.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107489/diff/
> 
> 
> Testing
> -------
> 
> Who tests the testers?
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121128/2e728830/attachment.html>