Review Request: (code deduplication) Use OutputExecuteJob in CMakeJob

Commit Hook null at kde.org
Sun Nov 18 10:11:36 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106465/#review22154
-----------------------------------------------------------


This review has been submitted with commit 62699ce663f4c7d2c95a64d15d5b975add8eaf7f by Ivan Shapovalov to branch master.

- Commit Hook


On Sept. 19, 2012, 4:39 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106465/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 4:39 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This is related to https://git.reviewboard.kde.org/r/106463/.
> So, CMakeJob is ported to use the class from given review.
> 
> 
> Diffs
> -----
> 
>   projectbuilders/cmakebuilder/cmakejob.h 6dd0a1a 
>   projectbuilders/cmakebuilder/cmakejob.cpp 5e4f159 
> 
> Diff: http://git.reviewboard.kde.org/r/106465/diff/
> 
> 
> Testing
> -------
> 
> Manual testing + existing unit-tests.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121118/bb6100cd/attachment.html>


More information about the KDevelop-devel mailing list