Review Request: (code deduplication) Use OutputExecuteJob in CMakeJob

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106465/#review22059
-----------------------------------------------------------

Ship it!


assuming this is still working as intended, I'd say go for it - every patch that removes code but keeps functionality is a good patch :)

- Milian Wolff


On Sept. 19, 2012, 4:39 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106465/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 4:39 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This is related to https://git.reviewboard.kde.org/r/106463/.
> So, CMakeJob is ported to use the class from given review.
> 
> 
> Diffs
> -----
> 
>   projectbuilders/cmakebuilder/cmakejob.h 6dd0a1a 
>   projectbuilders/cmakebuilder/cmakejob.cpp 5e4f159 
> 
> Diff: http://git.reviewboard.kde.org/r/106465/diff/
> 
> 
> Testing
> -------
> 
> Manual testing + existing unit-tests.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121115/d9266d8d/attachment.html>