Review Request: (code deduplication) use OutputExecuteJob in MakeJob

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106464/#review22060
-----------------------------------------------------------

Ship it!


assuming this is still working as intended, I'd say go for it - every patch that removes code but keeps functionality is a good patch :)

- Milian Wolff


On Sept. 19, 2012, 4:40 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106464/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2012, 4:40 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This is related to https://git.reviewboard.kde.org/r/106463/.
> So, MakeJob is ported to use the class from given review.
> 
> 
> Diffs
> -----
> 
>   projectbuilders/makebuilder/makejob.h 59d37c9 
>   projectbuilders/makebuilder/makejob.cpp 9d4b85e 
> 
> Diff: http://git.reviewboard.kde.org/r/106464/diff/
> 
> 
> Testing
> -------
> 
> Manual testing + existing unit tests.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121115/0d056169/attachment.html>