Review Request: (code deduplication) use OutputExecuteJob in MakeJob
Commit Hook
null at kde.org
Sun Nov 18 10:11:35 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106464/#review22153
-----------------------------------------------------------
This review has been submitted with commit 4f186d2d649859b8947a56b5504d0748380c324d by Ivan Shapovalov to branch master.
- Commit Hook
On Sept. 19, 2012, 4:40 p.m., Ivan Shapovalov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106464/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2012, 4:40 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> This is related to https://git.reviewboard.kde.org/r/106463/.
> So, MakeJob is ported to use the class from given review.
>
>
> Diffs
> -----
>
> projectbuilders/makebuilder/makejob.h 59d37c9
> projectbuilders/makebuilder/makejob.cpp 9d4b85e
>
> Diff: http://git.reviewboard.kde.org/r/106464/diff/
>
>
> Testing
> -------
>
> Manual testing + existing unit tests.
>
>
> Thanks,
>
> Ivan Shapovalov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121118/27a52d06/attachment.html>
More information about the KDevelop-devel
mailing list