Review Request: Segfault when opening project configuration for kdev-python project
Milian Wolff
mail at milianw.de
Sat Nov 17 17:20:30 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107291/#review22136
-----------------------------------------------------------
sorry I didn't see this and fixed it already (in a cleaner way):
commit abdb0e2bf3f2f867560d48ed24c30944a6488f5a
Author: Milian Wolff <mail at milianw.de>
Date: Fri Nov 16 17:34:03 2012 +0100
do not crash for projects without build system manager
BUG: 309913
- Milian Wolff
On Nov. 11, 2012, 6:12 a.m., David Knapp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107291/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2012, 6:12 a.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> Fixes a segfault crash due to a null pointer exception when opening the project configuration for a kdev-python project. The docs for IProject::buildSystemManager() says "@return the build system manager for the project, if one exists; otherwise null". The code previously however relied on that call returning a non-null pointer.
>
>
> Diffs
> -----
>
> shell/projectcontroller.cpp 6168066
>
> Diff: http://git.reviewboard.kde.org/r/107291/diff/
>
>
> Testing
> -------
>
> I can now open a config window for my python project
>
>
> Thanks,
>
> David Knapp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121117/bd61beb1/attachment.html>
More information about the KDevelop-devel
mailing list