Review Request: Segfault when opening project configuration for kdev-python project

[Ivan Shapovalov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107291/#review21920
-----------------------------------------------------------

Ship it!


Ah, I overlooked that when modified this code...


shell/projectcontroller.cpp
<http://git.reviewboard.kde.org/r/107291/#comment16873>

    One notice: wouldn't it be just more neat to use the if() statement below instead of introducing the second one?


- Ivan Shapovalov


On Nov. 11, 2012, 6:12 a.m., David Knapp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107291/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2012, 6:12 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fixes a segfault crash due to a null pointer exception when opening the project configuration for a kdev-python project. The docs for IProject::buildSystemManager() says "@return the build system manager for the project, if one exists; otherwise null". The code previously however relied on that call returning a non-null pointer.
> 
> 
> Diffs
> -----
> 
>   shell/projectcontroller.cpp 6168066 
> 
> Diff: http://git.reviewboard.kde.org/r/107291/diff/
> 
> 
> Testing
> -------
> 
> I can now open a config window for my python project
> 
> 
> Thanks,
> 
> David Knapp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121113/afa9d71a/attachment.html>